Announcement

**Oscar Jack** · 12-11-2013, 08:29 PM

Hi,

URLs for betting:

https://api.betfair.com/exchange/betting/json-rpc/v1

or

https://api.betfair.com/exchange/betting/rest/v1.0

URLs for account info:

https://api.betfair.com/exchange/account/json-rpc/v1

or

https://api.betfair.com/exchange/account/rest/v1.0

For cancelOrders: To cancel all the bet do not send "sizeReduction". Because you are sending 0.00 it thinks you want to reduce the size by zero so raises the error INVALID_BET_SIZE. I believe.

**monkeymagix** · 15-11-2013, 06:01 PM

I still get errors with the CancelBets method

Hi,

I have removed the sizeReduction value so I am cancelling the full bet. However if you notice from this debug. Even though the bet (a lay bet for �10 at 1.10) is getting placed AND then cancelled (I check in Betfair) the response still contains error messages.

The PlaceOrder contains "ERROR_IN_MATCHER" and "INVALID_BET_SIZE" and the CancelOrder contains the same!

I have also changed the end points but I still cannot login with Rescript whilst I can with Json-rpc e.g

BackUp Login Method = JsonRpcClient
In RescriptLogin
Try Logging in with RescriptLogin = https://api.betfair.com/exchange/betting, XXX , xxxxxxxxxxxxxxxxxx=
In RescriptClient endPoint before adding /rest/v1.0/ to it is https://api.betfair.com/exchange/betting
Now its https://api.betfair.com/exchange/betting/rest/v1.0/ appKey = XXX sessionToken = xxxxxxxxxxxxxxxxxx=
this.Client should be populated
Couldnt get a client object with RescriptClient!
RETURN False
Rescript Login Failed so try JsonRpcClientLogin
In JsonRpcClientLogin
In JsonRpcClient endPoint before adding /json-rpc/v1/ to it is https://api.betfair.com/exchange/betting
Now its https://api.betfair.com/exchange/betting/json-rpc/v1/ appKey = XXX sessionToken = xxxxxxxxxxxxxxxxxx=
RETURN True
We can login with this session and AppKey so return session: xxxxxxxxxxxxxxxxxx=

So I cannot login with Rescript still even though I am using the changed endpoint URL https://api.betfair.com/exchange/betting/rest/v1.0/

Also here is the place/cancel order which does place/cancel but the JSON contains errors - Betfair BDP say they cannot reproduce it so I have no clue to why it is working but still giving me errors. Especially seeing my code is based on their example C# code API-ING.

Instruction SelectionID: 5594022
Instruction OrderType: LIMIT
Instruction Side: LAY
EndPoint = https://api.betfair.com/exchange/betting/json-rpc/v1/

Calling: SportsAPING/v1.0/placeOrders With args: {"marketId":"1.111875578","instructions":[{"orderType":"LIMIT","selectionId":5594022,"handic ap":0.0,"side":"LAY","limitOrder":{"size":10.0,"pr ice":1.1,"persistenceType":"LAPSE"}}],"customerRef":"PlaceOrder_BetPK-10896210"}

Got Response: {"jsonrpc":"2.0","result":{"status":"SUCCESS","err orCode":"ERROR_IN_MATCHER","marketId":"1.111875578 ","instructionReports":[{"status":"SUCCESS","errorCode":"INVALID_BET_SIZE" ,"instruction":{"orderType":"LIMIT","selectionId": 5594022,"handicap":0.0,"side":"LAY","limitOrder":{ "size":10.0,"price":1.1,"persistenceType":"LAPSE"} },"betId":"31712836514","placedDate":"2013-11-15T16:58:02Z","averagePriceMatched":0.0,"sizeMatch ed":0.0}],"customerRef":"PlaceOrder_BetPK-10896210"},"id":1}
PlaceOrder Status = SUCCESS
PlaceOrder Success
Extract BetID from 31712836514
This Bet could not be fully matched at this point in time; Bet UnMatched; Any matched amount was 0; Current Match Status: U; Bet ID: 31712836514
Bet Message = Bet UnMatched
Bet was placed was okay; BetPK: 10896210; BetID: 31712836514
Now Cancel it!
CancelBet - BetID: 31712836514 - SizeReducton: 0;
IN CancelOrder
Instruction BetID: 31712836514
Instruction SizeReduction:
EndPoint = https://api.betfair.com/exchange/betting/json-rpc/v1/

Calling: SportsAPING/v1.0/cancelOrders With args: {"marketId":"1.111875578","instructions":[{"betId":"31712836514"}],"customerRef":"CancelOrder_BetPK-10896210"}

Got Response: {"jsonrpc":"2.0","result":{"status":"SUCCESS","err orCode":"ERROR_IN_MATCHER","marketId":"1.111875578 ","instructionReports":[{"status":"SUCCESS","errorCode":"INVALID_BET_SIZE" ,"instruction":{"betId":"31712836514"},"sizeCancel led":10.0}],"customerRef":"CancelOrder_BetPK-10896210"},"id":1}
Status = SUCCESS
CancelOrder Success - SizeCancelled = 10
Cancel Remaining Amount = 0
Cancel Status = C
Cancel Message = Bet Cancelled

So I don't know if you have any ideas about this or not?

I am having to write a lot of code to make the account libraries etc. So much work, so little time and so, so, much missing from the Betfair example code!

Thanks

**jim tollan** · 14-04-2014, 04:42 PM

Hello there,

I'm actually developing an api client in c# and am receiving exactly the same error statuses as you are. Like yourself, I'm using the sample from github. I've started to rely on the status of SUCCESS to drive my decision trees but it feels wrong that I'm ignoring these phantom errors (even tho they appear not to be errors).

Did you ever reach a resolution with this, whereby you managed to receive confirmation that didn't include the phantom errors??

Hope you can help as I really want to tidy my code up

All the best
jim

**monkeymagix** · 14-04-2014, 07:13 PM

Hi

I "think" it was the endpoint I was using.

Would have to check tomorrow but search all posts for monkeymagix to see if you can see anything I wrote back.

As for the errors in the responses with a success status it was because the first ENUM in the response class was not "NONE" it was either INVALID_BET_SIZE or ERROR_IN_MATCHER so it defaulted to an error. Add in NONE to those response classes as the first item, to fix that.

Cannot remember at home was the json rpc issue was at the moment.

**jim tollan** · 15-04-2014, 06:05 PM

monkeymagix - I actually found that problem yesterday and meant to report back on that. I actually approached it slightly differently and made the ErrorCodes nullable, therefore, no new faux enum values added to cope with this. My structure ended up:

public class PlaceExecutionReport==>
public ExecutionReportErrorCode? ErrorCode { get; set; }

and

public class PlaceInstructionReport==>
public InstructionReportErrorCode? ErrorCode { get; set; }

hope this adds to the discussion.

**monkeymagix** · 16-04-2014, 03:05 PM

Fix was

Hi

As for the Rescript issue I think it was because I was using old endpoints (dev not live) and I was trying to login to both the Client AND Account endpoints at the same time. As my code for the Account interface was not complete yet I was getting an error when I was trying to check that both objects were not null.

E.G when I run my BOT it constantly saves the session (or re-uses it if it needs a new one) and then logins with the appkey and session to either JSON or ReScript with the other as the backup.

The code to do the logging in (high up code) was like this (highlighted the erroring code)

Code:

private bool JsonRpcClientLogin()
        {
                
            bool success = false;

            // reset
            this.Client = null;
            this.Account = null;

            try
            {
            
                this.Client = new JsonRpcClient(BetfairAPI.BetfairAPIURL, BetfairAPI.APPKEY, this.SessionCode);
               

                this.Account = new JsonRpcClient(BetfairAPI.BetfairAccountURL, BetfairAPI.APPKEY, this.SessionCode);

             
            }
            catch (System.Exception ex)
            {
            

                return success;
            }

            // this was failing as this.Account WAS NULL due to me not finishing the code in that class. When it was finished it was ok
            if (this.Client != null && this.Account != null)
            {
                success = true;
            }
            else
            {
                this.HelperLib.LogMsg("Couldnt get a client object with JsonRpcClient!");
            }

            HelperLib.LogMsg("RETURN " + success.ToString());

            return success;
        }

Don't know if this helps or not as it was quite a specific error.

As for the enums I just did this.

Code:

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using Newtonsoft.Json;
using Newtonsoft.Json.Converters;

namespace Api_ng_sample_code.TO
{
    public enum CurrentBetStatus 
    {
        NONE ,
        MATCHED , // A matched bet
        UNMATCHED ,	// An unmatched bet
        LAPSED,	// Unmatched bet that was cancelled by Betfair (for example at turn in play).
        CANCELLED , // Unmatched bet that was cancelled by an explicit customer action.
        SETTLED , // a settled bet
        PARTIALLYMATCHED , // a partially matched bet
        PARTIALLYCANCELLED  // a partially cancelled bet
    }
}

and

Code:

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using Newtonsoft.Json;
using Newtonsoft.Json.Converters;

namespace Api_ng_sample_code.TO
{
    [JsonConverter(typeof(StringEnumConverter))]
    public enum InstructionReportErrorCode
    {
        OK,
        INVALID_BET_SIZE,					
        INVALID_RUNNER,						
        BET_TAKEN_OR_LAPSED,				
        BET_IN_PROGRESS,					
        RUNNER_REMOVED,						
        MARKET_NOT_OPEN_FOR_BETTING,		
        LOSS_LIMIT_EXCEEDED,				
        MARKET_NOT_OPEN_FOR_BSP_BETTING,	
        INVALID_PRICE_EDIT,					
        INVALID_ODDS,						
        INSUFFICIENT_FUNDS,					
        INVALID_PERSISTENCE_TYPE,			
        ERROR_IN_MATCHER,					
        INVALID_BACK_LAY_COMBINATION,		
        ERROR_IN_ORDER,						
        INVALID_BID_TYPE,					
        INVALID_BET_ID,						
        CANCELLED_NOT_PLACED,				
        RELATED_ACTION_FAILED,				
        NO_ACTION_REQUIRED,					
    }
}

I also added into the Place/CancelExecutionReport.cs this method so it defaults to OK

public class CancelExecutionReport
{
public CancelExecutionReport()
{
ErrorCode = ExecutionReportErrorCode.OK;
}

So that it always defaulted to OK UNLESS an ERROR DID occur.

Thanks

Rob

**monkeymagix** · 16-04-2014, 03:06 PM

Actually

Actually I think the 2nd from last bit of code wasn't anything to do with it e.g the BetStatus ENUM

**jim tollan** · 17-04-2014, 01:41 PM

monkeymagix,

Be very careful when adding new enums to the TOP of the enum stack as the default first entry is always zero (unless you supply a value). Therefore, you stand a good chance of parsing all your errorcodes shifted by 1 given those changes. This may or may not be an issue as you may have accommodated for this.

And thanks for the code snippets, I too cache my session token and only login when required, so I think we're on the same page there. And likewise, I keep my accounts and betting objects as seperate dll's which only share the login token and appid.

Nice to chat -cheers again
jim

Announcement

Why can I login to Rescript but not JsonRpc Client? And Problems Cancelling Bets

Why can I login to Rescript but not JsonRpc Client? And Problems Cancelling Bets

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment